Open hyperlinks in new browser window ?

Posted on 20 Jan 2010, 15:20:13

Access: Member
Total Posts: 20
Joined: 2009-08-13

Hi

How can this be achieved? Is there a single setting, or does this have to be set for each hyperlink?

I display N13 in an iframe ... which at 45opix wide is too small for a full web page.

Thanks

David

#1637

Chris

Posted on 20 Jan 2010, 15:52:02

Access: Admin
Total Posts: 1395
Joined: 2006-05-19

Options > System > Comments > Show comments in new window: Yes

#1638

Davidmcc3

Posted on 20 Jan 2010, 16:39:43

Access: Member
Total Posts: 20
Joined: 2009-08-13

Hi.

Set this ... no effect ... linked websites still come up inside the iframe

David

#1639

Chris

Posted on 20 Jan 2010, 17:23:58

Access: Admin
Total Posts: 1395
Joined: 2006-05-19

Ah I thought you meant the link to open the comments page.

If you edit the bbparser.php file, around line 102~ you'll see this line

Code:


$bb2html = preg_replace("/\[url=(\W?)(.*?)(\W?)\](.*?)\[\/url\]/", '<a href="/thread/1637-Open-hyperlinks-in-new-browser-window/sort_Thread.created/$2">$4</a>', $bb2html);

change that to

Code:


$bb2html = preg_replace("/\[url=(\W?)(.*?)(\W?)\](.*?)\[\/url\]/", '<a target="_NEW" href="/thread/1637-Open-hyperlinks-in-new-browser-window/sort_Thread.created/$2">$4</a>', $bb2html);

the links you create should now open in a new window.

I'll change this in the next version so that when you set that system option to open the comments link in a new window, it'll also affect links you create as well.

And just out of curiosity, I see you're subscribed to this thread, did it send you an email properly when I replied to it? was it marked as spam or anything?

#1640

Last edited by Chris at 2010-01-20 18:02:53 Reason:

Davidmcc3

Posted on 20 Jan 2010, 22:19:20

Access: Member
Total Posts: 20
Joined: 2009-08-13

Hi Chris

Thanks for the info ... I'll edit the file tomorrow (and document it so I don't forget!).

I've checked my emails, and I've not had one ... I've spoken to my hosting company and they have a fairly agressive spam filter in place which is activated when a message is forwarded (this is our forward set up to an email archive).

I'll change my registered email address to one which operates outside this ... then we'll see if the message gets through.

Regards

David

#1641

Davidmcc3

Posted on 21 Jan 2010, 14:55:14

Access: Member
Total Posts: 20
Joined: 2009-08-13

Hi Chris.

Made change as directed ... but it broke N13 ... got this error:

Warning: Missing argument 3 for bb2html(), called in /home/lrmcom/public_html/N13-news/functions.php on line 454 and defined in /home/lrmcom/public_html/N13-news/bbparser.php on line 33

Warning: mysql_query() [function.mysql-query]: Access denied for user 'lrmcom'@'localhost' (using password: NO) in /home/lrmcom/public_html/N13-news/bbparser.php on line 109

Warning: mysql_query() [function.mysql-query]: A link to the server could not be established in /home/lrmcom/public_html/N13-news/bbparser.php on line 109
Access denied for user 'lrmcom'@'localhost' (using password: NO)

Could you help?

Thanks

David

#1661

Chris

Posted on 21 Jan 2010, 19:09:55

Access: Admin
Total Posts: 1395
Joined: 2006-05-19

Are you using a version prior to 3.4? I assumed you were using 3.4 which is what my previous message was coded for.

#1665

Davidmcc3

Posted on 21 Jan 2010, 20:44:42

Access: Member
Total Posts: 20
Joined: 2009-08-13

Hi

I had installed 3.2, but then found 3.4 on your site and performed the upgrade.

Does this help?

Thanks

PS. Email notification got through OK this time.

#1666

Chris

Posted on 21 Jan 2010, 20:48:58

Access: Admin
Total Posts: 1395
Joined: 2006-05-19

If you're getting error messages like

Code:


Warning: mysql_query

That means the upgrade may have went wrong or some of the files have been changed back to the 3.2 versions. When you edited the bbparser file, could it be possible that you edited the 3.2 version of the file then uploaded that?

The reason is ask is the system no longer uses mysql_query so it would only show that error if it was using an older file.

#1667

Davidmcc3

Posted on 21 Jan 2010, 22:24:27

Access: Member
Total Posts: 20
Joined: 2009-08-13

I'm out for some days now - I'll start from the beginning with 3.4 and post back if I'm still having problems. Thanks for your help.

#1668